Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11225 )
Change subject: tests: ensure consistent logging format across tests ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/11225/1/tests/common/impala_cluster.py File tests/common/impala_cluster.py: http://gerrit.cloudera.org:8080/#/c/11225/1/tests/common/impala_cluster.py@36 PS1, Line 36: LOG.setLevel(level=logging.DEBUG) > This line is "global" too, though I think it's intentional. isn't this just setting the log level for this particular logger? http://gerrit.cloudera.org:8080/#/c/11225/1/tests/conftest.py File tests/conftest.py: http://gerrit.cloudera.org:8080/#/c/11225/1/tests/conftest.py@51 PS1, Line 51: def pytest_configure(config): > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/11225/1/tests/conftest.py@56 PS1, Line 56: logging.basicConfig(level=logging.INFO, format='-- %(threadName)s: %(message)s') > +1 for a timestamp Done -- To view, visit http://gerrit.cloudera.org:8080/11225 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I55ef0214b43f87da2d71804913ba4caa964f789f Gerrit-Change-Number: 11225 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 17 Aug 2018 23:22:16 +0000 Gerrit-HasComments: Yes
