Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11253 )
Change subject: IMPALA-7457. statestore: allow filtering by key prefix ...................................................................... Patch Set 1: > High level question: are string keys the right abstraction or would something > more structured (e.g. tags or structured keys like a.b.c)be more maintainable? > I suspect that would be overengineering but felt compelled to ask since > playing tricks with strings does often turn into tech debt. Yea, I considered this for a bit. My first implementation actually added a 'category' that went along with the value, but then I ran into complexities on what happens if multiple entries exist with the same name but different categories -- the category would have to become part of the key in the map. That led me to looking at changing all of the map<string, ...> structures to map<EntryKey> with some struct, which started to turn into a pretty large change across tests and lots of call sites. So, I went with the shorter term key prefix solution here despite it being a little bit hacky -- To view, visit http://gerrit.cloudera.org:8080/11253 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ddcf3bfaf16bc3cd1ba01100e948ff142a67620 Gerrit-Change-Number: 11253 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Fri, 17 Aug 2018 18:03:46 +0000 Gerrit-HasComments: No
