Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11253 )
Change subject: IMPALA-7457. statestore: allow filtering by key prefix ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11253/1/be/src/statestore/statestore-subscriber.cc File be/src/statestore/statestore-subscriber.cc: http://gerrit.cloudera.org:8080/#/c/11253/1/be/src/statestore/statestore-subscriber.cc@142 PS1, Line 142: std::s > nit: std:: not needed in .cc Done http://gerrit.cloudera.org:8080/#/c/11253/1/be/src/statestore/statestore.h File be/src/statestore/statestore.h: http://gerrit.cloudera.org:8080/#/c/11253/1/be/src/statestore/statestore.h@277 PS1, Line 277: void BuildDelta(const SubscriberId& subscriber_id, TopicEntry::Version last_processed_version, > line too long (98 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/11253 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ddcf3bfaf16bc3cd1ba01100e948ff142a67620 Gerrit-Change-Number: 11253 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Sat, 18 Aug 2018 04:33:50 +0000 Gerrit-HasComments: Yes