Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11253 )
Change subject: IMPALA-7457. statestore: allow filtering by key prefix ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Thanks for the explanation, I agree with the reasoning. I don't think it makes sense to invest effort into generalising the statestore interface when it has only a small number of use cases. http://gerrit.cloudera.org:8080/#/c/11253/1/be/src/statestore/statestore-subscriber.cc File be/src/statestore/statestore-subscriber.cc: http://gerrit.cloudera.org:8080/#/c/11253/1/be/src/statestore/statestore-subscriber.cc@142 PS1, Line 142: std::s nit: std:: not needed in .cc -- To view, visit http://gerrit.cloudera.org:8080/11253 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ddcf3bfaf16bc3cd1ba01100e948ff142a67620 Gerrit-Change-Number: 11253 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Fri, 17 Aug 2018 18:26:37 +0000 Gerrit-HasComments: Yes
