Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11231 )
Change subject: IMPALA-7447. Evict LocalCatalog cache entries based on size ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/11231/3/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: http://gerrit.cloudera.org:8080/#/c/11231/3/be/src/runtime/exec-env.cc@90 PS3, Line 90: nit: get rid of extra spaces (here and several words to the right) http://gerrit.cloudera.org:8080/#/c/11231/3/common/thrift/BackendGflags.thrift File common/thrift/BackendGflags.thrift: http://gerrit.cloudera.org:8080/#/c/11231/3/common/thrift/BackendGflags.thrift@87 PS3, Line 87: seconds for seconds, seems we just use "s" as a suffix. lets go with that for now for consistency. http://gerrit.cloudera.org:8080/#/c/11231/3/fe/src/test/java/org/apache/impala/catalog/local/CatalogdMetaProviderTest.java File fe/src/test/java/org/apache/impala/catalog/local/CatalogdMetaProviderTest.java: http://gerrit.cloudera.org:8080/#/c/11231/3/fe/src/test/java/org/apache/impala/catalog/local/CatalogdMetaProviderTest.java@111 PS3, Line 111: // the size loosely. for timing, does guava offer an interface to accept a fake clock to make time-based testing easier? for size-based tests, if the number of entries can be accessed from the cache, perhaps dialing it down can test whether the cache contains expected number of entries. -- To view, visit http://gerrit.cloudera.org:8080/11231 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia96af49b35c17e505b7b6785e78d140939085d91 Gerrit-Change-Number: 11231 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Sun, 19 Aug 2018 20:19:46 +0000 Gerrit-HasComments: Yes
