Vuk Ercegovac has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11231 )

Change subject: IMPALA-7447. Evict LocalCatalog cache entries based on size
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11231/3/fe/src/test/java/org/apache/impala/catalog/local/CatalogdMetaProviderTest.java
File 
fe/src/test/java/org/apache/impala/catalog/local/CatalogdMetaProviderTest.java:

http://gerrit.cloudera.org:8080/#/c/11231/3/fe/src/test/java/org/apache/impala/catalog/local/CatalogdMetaProviderTest.java@111
PS3, Line 111:     // the size loosely.
> for timing, does guava offer an interface to accept a fake clock to make ti
nm the last point about sizes... saw that the other change (other tests in this 
file) address that.



--
To view, visit http://gerrit.cloudera.org:8080/11231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia96af49b35c17e505b7b6785e78d140939085d91
Gerrit-Change-Number: 11231
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com>
Gerrit-Comment-Date: Sun, 19 Aug 2018 20:23:53 +0000
Gerrit-HasComments: Yes

Reply via email to