Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11231 )
Change subject: IMPALA-7447. Evict LocalCatalog cache entries based on size ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/11231/3/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: http://gerrit.cloudera.org:8080/#/c/11231/3/be/src/runtime/exec-env.cc@90 PS3, Line 90: > nit: get rid of extra spaces (here and several words to the right) Done http://gerrit.cloudera.org:8080/#/c/11231/3/common/thrift/BackendGflags.thrift File common/thrift/BackendGflags.thrift: http://gerrit.cloudera.org:8080/#/c/11231/3/common/thrift/BackendGflags.thrift@87 PS3, Line 87: seconds > for seconds, seems we just use "s" as a suffix. lets go with that for now f Done -- To view, visit http://gerrit.cloudera.org:8080/11231 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia96af49b35c17e505b7b6785e78d140939085d91 Gerrit-Change-Number: 11231 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Mon, 20 Aug 2018 23:14:11 +0000 Gerrit-HasComments: Yes
