Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11296 )

Change subject: IMPALA-7418: Return first non-ok status from 
HdfsScanNode::GetNext()
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/11296/1/be/src/exec/hdfs-scan-node.cc
File be/src/exec/hdfs-scan-node.cc:

http://gerrit.cloudera.org:8080/#/c/11296/1/be/src/exec/hdfs-scan-node.cc@87
PS1, Line 87:     Status status = IssueInitialScanRanges(state);
Let's update the IssueInitialScanRanges() comment to explain the cases when it 
returns a non-OK status (i.e. an error issuing the ranges or the 
reader_context_ being cancelled).


http://gerrit.cloudera.org:8080/#/c/11296/1/be/src/exec/hdfs-scan-node.cc@88
PS1, Line 88:     if (!status.ok()) {
I'd suggest adding a brief comment explaining this. E.g.

"If a scanner thread hit an error and cancelled reader_context_, the scanner 
thread's error must take precedence."


http://gerrit.cloudera.org:8080/#/c/11296/1/be/src/exec/hdfs-scan-node.cc@90
PS1, Line 90: status.IsCancelled() &&
I think we can remove this IsCancelled() check. It seems ok if status_ always 
takes precedence.



--
To view, visit http://gerrit.cloudera.org:8080/11296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4569cc7b0843a29c617a094e590c31f7c648ff45
Gerrit-Change-Number: 11296
Gerrit-PatchSet: 1
Gerrit-Owner: Pooja Nilangekar <[email protected]>
Gerrit-Reviewer: Bikramjeet Vig <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Pooja Nilangekar <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Wed, 22 Aug 2018 21:43:22 +0000
Gerrit-HasComments: Yes

Reply via email to