Pooja Nilangekar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11296 )

Change subject: IMPALA-7418: Return first non-ok status from 
HdfsScanNode::GetNext()
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/11296/1/be/src/exec/hdfs-scan-node.cc
File be/src/exec/hdfs-scan-node.cc:

http://gerrit.cloudera.org:8080/#/c/11296/1/be/src/exec/hdfs-scan-node.cc@87
PS1, Line 87:     // IssueInitialScanRanges() returns a non-ok status if 
ValidateScanRange() fails or
> Let's update the IssueInitialScanRanges() comment to explain the cases when
Done


http://gerrit.cloudera.org:8080/#/c/11296/1/be/src/exec/hdfs-scan-node.cc@88
PS1, Line 88:     // the request_context_ is cancelled before all scan ranges 
are added.
> I'd suggest adding a brief comment explaining this. E.g.
Done


http://gerrit.cloudera.org:8080/#/c/11296/1/be/src/exec/hdfs-scan-node.cc@90
PS1, Line 90: tatus.ok()) {
> I think we can remove this IsCancelled() check. It seems ok if status_ alwa
Apart from reader_context_ being cancelled, there are failure modes for 
IssueInitialScanRanges(). For example, invalid file length for Parquet and Orc 
files, unsupported compression formats for text files or if ValidateScanRange 
fails. In those cases, shouldn't the status returned take precedence over 
status_?



--
To view, visit http://gerrit.cloudera.org:8080/11296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4569cc7b0843a29c617a094e590c31f7c648ff45
Gerrit-Change-Number: 11296
Gerrit-PatchSet: 2
Gerrit-Owner: Pooja Nilangekar <[email protected]>
Gerrit-Reviewer: Bikramjeet Vig <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Pooja Nilangekar <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Wed, 22 Aug 2018 22:31:32 +0000
Gerrit-HasComments: Yes

Reply via email to