Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11296 )
Change subject: IMPALA-7418: Return first non-ok status from HdfsScanNode::GetNext() ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/11296/1/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: http://gerrit.cloudera.org:8080/#/c/11296/1/be/src/exec/hdfs-scan-node.cc@90 PS1, Line 90: eader_context_ was cance > Ahh ok, I see your point - I think those errors from IssueInitialScanRanges Done http://gerrit.cloudera.org:8080/#/c/11296/2/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: http://gerrit.cloudera.org:8080/#/c/11296/2/be/src/exec/hdfs-scan-node.cc@87 PS2, Line 87: Status status = IssueInitialScanRanges(state); > I think we want the comment in the header where IssueInitialScanRanges() is Done -- To view, visit http://gerrit.cloudera.org:8080/11296 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4569cc7b0843a29c617a094e590c31f7c648ff45 Gerrit-Change-Number: 11296 Gerrit-PatchSet: 3 Gerrit-Owner: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 22 Aug 2018 23:08:38 +0000 Gerrit-HasComments: Yes
