Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11306 )

Change subject: IMPALA-7351: Improve memory estimates for Hbase Scan Nodes
......................................................................


Patch Set 1:

(5 comments)

Some initial comments. Didn't have time to do a full review yet

http://gerrit.cloudera.org:8080/#/c/11306/1/be/src/runtime/mem-pool.h
File be/src/runtime/mem-pool.h:

http://gerrit.cloudera.org:8080/#/c/11306/1/be/src/runtime/mem-pool.h@55
PS1, Line 55: enforce_binary_chunk_sizes
"binary" feels like a non-obvious way to describe it. Maybe "po2" instead?


http://gerrit.cloudera.org:8080/#/c/11306/1/be/src/runtime/mem-pool.cc
File be/src/runtime/mem-pool.cc:

http://gerrit.cloudera.org:8080/#/c/11306/1/be/src/runtime/mem-pool.cc@132
PS1, Line 132:   if(enforce_binary_chunk_sizes_) chunk_size = 
BitUtil::RoundUpToPowerOfTwo(chunk_size);
whitespace


http://gerrit.cloudera.org:8080/#/c/11306/1/fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java
File fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java:

http://gerrit.cloudera.org:8080/#/c/11306/1/fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java@511
PS1, Line 511:   public void computeNodeResourceProfile(TQueryOptions 
queryOptions) {
This function feels slightly too large - it's hard to understand the 
calculation. Is there a way to break it into functions? I tried to come up with 
a concrete suggestion but didn't have something right away.


http://gerrit.cloudera.org:8080/#/c/11306/1/fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java@517
PS1, Line 517:     // allocate-clear cycle on mem-pool for each row fetched 
from hbase. To get an approx
Can you cross-reference from the be code?


http://gerrit.cloudera.org:8080/#/c/11306/1/fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java@565
PS1, Line 565: mem_estiamte
typo



--
To view, visit http://gerrit.cloudera.org:8080/11306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I583545c3f5e454854f111871c5fbc4f108ae4bff
Gerrit-Change-Number: 11306
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Thu, 23 Aug 2018 21:50:51 +0000
Gerrit-HasComments: Yes

Reply via email to