Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11306 )
Change subject: IMPALA-7351: Improve memory estimates for Hbase Scan Nodes ...................................................................... Patch Set 1: (1 comment) Did another pass - my main concerns are testing (which you're working on) and the understandability of the estimation method (which I mentioned earlier). http://gerrit.cloudera.org:8080/#/c/11306/1/be/src/exec/hbase-table-scanner.cc File be/src/exec/hbase-table-scanner.cc: http://gerrit.cloudera.org:8080/#/c/11306/1/be/src/exec/hbase-table-scanner.cc@107 PS1, Line 107: value_pool_(new MemPool(scan_node_->mem_tracker(),true)), whitespace -- To view, visit http://gerrit.cloudera.org:8080/11306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I583545c3f5e454854f111871c5fbc4f108ae4bff Gerrit-Change-Number: 11306 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 24 Aug 2018 20:36:39 +0000 Gerrit-HasComments: Yes
