Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11306 )
Change subject: IMPALA-7353: Improve memory estimates for Hbase Scan Nodes ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11306/2/fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java File fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java: http://gerrit.cloudera.org:8080/#/c/11306/2/fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java@548 PS2, Line 548: isStatsMissing > whoops, I was only trying to follow the convention that all boolean vars ha Yeah I think the intention was good, my brain just doesn't like ungrammatical-sounding variable names. isMissingStats seems fine. -- To view, visit http://gerrit.cloudera.org:8080/11306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I583545c3f5e454854f111871c5fbc4f108ae4bff Gerrit-Change-Number: 11306 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 17 Sep 2018 23:10:46 +0000 Gerrit-HasComments: Yes
