Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11181 )
Change subject: IMPALA-7421. Static methods use wrong JNI call function ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/11181/2/be/src/service/frontend.cc File be/src/service/frontend.cc: http://gerrit.cloudera.org:8080/#/c/11181/2/be/src/service/frontend.cc@229 PS2, Line 229: if (!err.empty()) { : return Status(err); > single line. Done http://gerrit.cloudera.org:8080/#/c/11181/2/be/src/util/jni-util.h File be/src/util/jni-util.h: http://gerrit.cloudera.org:8080/#/c/11181/2/be/src/util/jni-util.h@273 PS2, Line 273: ObjectToResult > Digging into this, more information in IMPALA-2615 and Done http://gerrit.cloudera.org:8080/#/c/11181/2/be/src/util/jni-util.h@451 PS2, Line 451: || > Make it more strict with ^? Done http://gerrit.cloudera.org:8080/#/c/11181/2/be/src/util/jni-util.h@472 PS2, Line 472: jstring jstr = static_cast<jstring>(obj); : const char *str = env_->GetStringUTFChars(jstr, &is_copy); : RETURN_ERROR_IF_EXC(env_); : *result = str; : env_->ReleaseStringUTFChars(jstr, str); : RETURN_ERROR_IF_EXC(env_); > Use JniUtfCharGuard? Done -- To view, visit http://gerrit.cloudera.org:8080/11181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If7cde6ca91613b63afe5307f4d819fb24cb17fd6 Gerrit-Change-Number: 11181 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 16 Aug 2018 00:05:26 +0000 Gerrit-HasComments: Yes
