Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 )
Change subject: IMPALA-376: add built-in functions for parsing JSON ...................................................................... Patch Set 11: (3 comments) Thanks for applying the changes. Found 2 smaller issues. http://gerrit.cloudera.org:8080/#/c/10950/11/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/10950/11/be/src/exprs/expr-test.cc@8816 PS11, Line 8816: TestError("get_json_object('[1,2]', '$[-2]')"); : TestError("get_json_object('[1,2]', '$[0.1]')"); : TestError("get_json_object('[1,2]', '$[a]')"); : : TestError("get_json_object('{\"key\": {\"a\": 1}}', '$..a')"); : TestError("get_json_object('{\"key\": \"value\"}', '$$')"); : TestError("get_json_object('{\"a\": 1}', '$a')"); : TestError("get_json_object('{\"a\": 1}', 'a')"); : TestError("get_json_object('[1,2,3]', '$[**]')"); > Sure. I think we should align with MySQL in corner cases, since Hive's impl Yeah, that's my impression too. http://gerrit.cloudera.org:8080/#/c/10950/11/be/src/exprs/string-functions.cc File be/src/exprs/string-functions.cc: http://gerrit.cloudera.org:8080/#/c/10950/11/be/src/exprs/string-functions.cc@129 PS11, Line 129: if (it->IsNull()) continue; > Done. Nice find! It's still in PS12. Please also add a test case for the statement above. http://gerrit.cloudera.org:8080/#/c/10950/12/be/src/exprs/string-functions.cc File be/src/exprs/string-functions.cc: http://gerrit.cloudera.org:8080/#/c/10950/12/be/src/exprs/string-functions.cc@235 PS12, Line 235: static const int would be better. -- To view, visit http://gerrit.cloudera.org:8080/10950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a9d3598cb3beca0865a7edb094f3a5b602dbd2f Gerrit-Change-Number: 10950 Gerrit-PatchSet: 11 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 27 Aug 2018 10:37:52 +0000 Gerrit-HasComments: Yes
