Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 )
Change subject: IMPALA-376: add built-in functions for parsing JSON ...................................................................... Patch Set 13: I didn't do anything that sophisticated - just wrote a python test that flipped bytes in HDFS files: https://github.com/apache/impala/blob/master/tests/query_test/test_scanners_fuzz.py#L35 Taras did some randomised testing of our decimal implementation here: https://github.com/apache/impala/blob/master/tests/query_test/test_decimal_fuzz.py We can also add things to the random query generator which validates them against postgres but I don't think there's a close enough postgres function to validate against: https://github.com/apache/impala/blob/master/tests/comparison/funcs.py#L574 -- To view, visit http://gerrit.cloudera.org:8080/10950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a9d3598cb3beca0865a7edb094f3a5b602dbd2f Gerrit-Change-Number: 10950 Gerrit-PatchSet: 13 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 28 Aug 2018 04:29:28 +0000 Gerrit-HasComments: No
