Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 )
Change subject: IMPALA-376: add built-in functions for parsing JSON ...................................................................... Patch Set 13: > We can also add things to the random query generator which validates them > against postgres but I don't think there's a close enough postgres function > to validate against: > https://github.com/apache/impala/blob/master/tests/comparison/funcs.py#L574 Yes, postgres has a quite different syntax for JSON: https://www.postgresql.org/docs/9.6/static/functions-json.html It'd be better if we can test against MySQL, since it's output is more robust and reasonable than Hive's. I found there's a template file about MySQL: https://github.com/apache/impala/blob/master/fe/src/test/resources/mysql-hive-site.xml.template Looks like we used to depend on MySQL in the past? Is it hard to enable it back? Or maybe we can just pull a MySQL docker image and use it. -- To view, visit http://gerrit.cloudera.org:8080/10950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a9d3598cb3beca0865a7edb094f3a5b602dbd2f Gerrit-Change-Number: 10950 Gerrit-PatchSet: 13 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 28 Aug 2018 04:51:06 +0000 Gerrit-HasComments: No
