Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11337 )
Change subject: IMPALA-7335: Fix a race in HdfsScanNode ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/11337/1/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: http://gerrit.cloudera.org:8080/#/c/11337/1/be/src/exec/hdfs-scan-node.cc@398 PS1, Line 398: } : // Set status_ before cal > does that still work as expected now that ProcessSplit already set status_? Yes, since StartNextScanRange() returns a status. I have changed this part a little to make it explicit that the ScannerThread() function only needs to handle errors from StartNextScanRange(). http://gerrit.cloudera.org:8080/#/c/11337/1/be/src/exec/hdfs-scan-node.cc@401 PS1, Line 401: status_ = status; : SetDoneInternal(); : break; : } else if (scan_range != nullptr) { : // Got a scan range. Process the range end to end (in this thread). : status = ProcessSplit(filter_status.ok() ? filter_ctxs : vector<FilterContext>(), : &expr_results_pool, scan_range, &scanner_thread_reservation); : // If ProcessSplit() returns an error, it would have updated the status_ variable : // and set the done_ flag if necessary. Exit the loop. : > can this be removed now that it's handled in ProcessSplit()? Hmm, I guess w Done. I have added a comment. http://gerrit.cloudera.org:8080/#/c/11337/1/be/src/exec/hdfs-scan-node.cc@514 PS1, Line 514: // If status is the first non-ok status returned by any scanner thread, update > It seems like the whole scanner thread protocol could really use a cleanup. Done. Yes, this code needs a clean up. This is a temporary fix for the broken builds. -- To view, visit http://gerrit.cloudera.org:8080/11337 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id470818846a5c69ad28a6ff695069702982aa793 Gerrit-Change-Number: 11337 Gerrit-PatchSet: 2 Gerrit-Owner: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 28 Aug 2018 00:27:55 +0000 Gerrit-HasComments: Yes
