Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/11337 )
Change subject: IMPALA-7335: Fix a race in HdfsScanNode ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11337/2/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: http://gerrit.cloudera.org:8080/#/c/11337/2/be/src/exec/hdfs-scan-node.cc@515 PS2, Line 515: Ensure that : // status_ is updated before the done_ flag. that was already true in the old code, no? Is the requirement also that this happens before scanner->Close()? It's unfortunate that this code is still duplicated here and in the caller and the errors are handled asymmetrical. An alternative would be to move lines 526-530 into the caller, but I guess that might be just as messy. -- To view, visit http://gerrit.cloudera.org:8080/11337 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id470818846a5c69ad28a6ff695069702982aa793 Gerrit-Change-Number: 11337 Gerrit-PatchSet: 2 Gerrit-Owner: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 28 Aug 2018 18:27:45 +0000 Gerrit-HasComments: Yes
