Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11337 )
Change subject: IMPALA-7335: Fix a race in HdfsScanNode ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/11337/2/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: http://gerrit.cloudera.org:8080/#/c/11337/2/be/src/exec/hdfs-scan-node.cc@515 PS2, Line 515: Ensure that : // status_ is updated before marking a range > that was already true in the old code, no? Is the requirement also that thi Actually, that was due to the race. A thread upon hitting an error closed the scanner and marked the scan range as complete. Another thread would loop around and notice that the progress has completed and hence set the done_ flag. I have changed the comments a bit to describe that. I agree this looks messy however I can't think of a clean way to handle this in the current state. Would it help to add a helper function to set the status and set the done_ flag? It would still be redundant but atleast we won't have code duplication? -- To view, visit http://gerrit.cloudera.org:8080/11337 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id470818846a5c69ad28a6ff695069702982aa793 Gerrit-Change-Number: 11337 Gerrit-PatchSet: 3 Gerrit-Owner: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 28 Aug 2018 22:05:27 +0000 Gerrit-HasComments: Yes
