Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/11339 )
Change subject: IMPALA-7464: fix race when ExecFInstance() RPC times out ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11339/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11339/2//COMMIT_MSG@21 PS2, Line 21: (verified via code inspection) I'd appreciate the code reviewer to verify this as well. http://gerrit.cloudera.org:8080/#/c/11339/2//COMMIT_MSG@24 PS2, Line 24: aren't particularly good at verifying it I thought about requiring a RuntimeState to be passed when accessing these resources (which would prove that the accesses are coming from the backend side) but that seemed cumbersome. -- To view, visit http://gerrit.cloudera.org:8080/11339 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If60d983e0e68b00e6557185db1f86757ab8b3f2d Gerrit-Change-Number: 11339 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Hecht <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 28 Aug 2018 17:11:45 +0000 Gerrit-HasComments: Yes
