Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/11339 )
Change subject: IMPALA-7464: fix race when ExecFInstance() RPC times out ...................................................................... Patch Set 3: Code-Review+2 (4 comments) Carry +2 http://gerrit.cloudera.org:8080/#/c/11339/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11339/2//COMMIT_MSG@24 PS2, Line 24: aren't particularly good at verifying it > We actually pass a RuntimeState* into PlanRootSink::GetNext() from the coor yeah, that's true, and agree that's weird. http://gerrit.cloudera.org:8080/#/c/11339/2/be/src/runtime/query-state.h File be/src/runtime/query-state.h: http://gerrit.cloudera.org:8080/#/c/11339/2/be/src/runtime/query-state.h@133 PS2, Line 133: back > backend Done http://gerrit.cloudera.org:8080/#/c/11339/2/be/src/runtime/query-state.h@152 PS2, Line 152: back > backend? Done http://gerrit.cloudera.org:8080/#/c/11339/2/be/src/runtime/query-state.h@408 PS2, Line 408: M > extra space Done -- To view, visit http://gerrit.cloudera.org:8080/11339 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If60d983e0e68b00e6557185db1f86757ab8b3f2d Gerrit-Change-Number: 11339 Gerrit-PatchSet: 3 Gerrit-Owner: Dan Hecht <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 29 Aug 2018 01:07:53 +0000 Gerrit-HasComments: Yes
