Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11339 )
Change subject: IMPALA-7464: fix race when ExecFInstance() RPC times out ...................................................................... Patch Set 2: Code-Review+2 (4 comments) This makes sense to me. I looked through the coordinator code to understand how it used structures obtained from the query state and it looks ok http://gerrit.cloudera.org:8080/#/c/11339/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11339/2//COMMIT_MSG@24 PS2, Line 24: aren't particularly good at verifying it > I thought about requiring a RuntimeState to be passed when accessing these We actually pass a RuntimeState* into PlanRootSink::GetNext() from the coordinator anyway so it doesn't necessarily prove anything :). Although we should probably remove that - it's a weird bit of plumbing. http://gerrit.cloudera.org:8080/#/c/11339/2/be/src/runtime/query-state.h File be/src/runtime/query-state.h: http://gerrit.cloudera.org:8080/#/c/11339/2/be/src/runtime/query-state.h@133 PS2, Line 133: exec backend http://gerrit.cloudera.org:8080/#/c/11339/2/be/src/runtime/query-state.h@152 PS2, Line 152: exec backend? http://gerrit.cloudera.org:8080/#/c/11339/2/be/src/runtime/query-state.h@408 PS2, Line 408: extra space -- To view, visit http://gerrit.cloudera.org:8080/11339 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If60d983e0e68b00e6557185db1f86757ab8b3f2d Gerrit-Change-Number: 11339 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Hecht <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 28 Aug 2018 23:02:16 +0000 Gerrit-HasComments: Yes
