Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11369 )
Change subject: IMPALA-7517. Fix hang in scanner threads when soft limit is exceeded ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11369/1/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: http://gerrit.cloudera.org:8080/#/c/11369/1/be/src/exec/hdfs-scan-node.cc@440 PS1, Line 440: "HDFS_SCANNER_THREAD_CHECK_SOFT_MEM_LIMIT").ok())) { I considered adding this fault injection more globally in MemTracker, but was wondering about performance characteristics. Is MemTracker::AnyLimitExceeded a hot enough path that the extra branch would be a concern to do it there and cover all places where we check soft limits? Maybe that would turn up some other bugs. -- To view, visit http://gerrit.cloudera.org:8080/11369 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3dc1a2ec79c823575d7d40e7b52216dea5b0ddde Gerrit-Change-Number: 11369 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 30 Aug 2018 23:00:19 +0000 Gerrit-HasComments: Yes
