Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11369 )
Change subject: IMPALA-7517. Fix hang in scanner threads when soft limit is exceeded ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Thanks for fixing it. This makes sense to me. I checked https://gerrit.cloudera.org/#/c/11103/ and didn't see the same problem in Kudu scan node. Please double check if you haven't done so already. http://gerrit.cloudera.org:8080/#/c/11369/1/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: http://gerrit.cloudera.org:8080/#/c/11369/1/be/src/exec/hdfs-scan-node.cc@440 PS1, Line 440: "HDFS_SCANNER_THREAD_CHECK_SOFT_MEM_LIMIT").ok())) { > I considered adding this fault injection more globally in MemTracker, but w I think it's reasonable to add it here for now but please feel free to do a follow on change to add it to MemTracker::AnyLimitExceeded(). At the bare minimum, we can enable it in debug builds only. This will definitely help exercise rarely exercised error handling paths in code. -- To view, visit http://gerrit.cloudera.org:8080/11369 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3dc1a2ec79c823575d7d40e7b52216dea5b0ddde Gerrit-Change-Number: 11369 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 31 Aug 2018 02:24:05 +0000 Gerrit-HasComments: Yes
