Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11369 )
Change subject: IMPALA-7517. Fix hang in scanner threads when soft limit is exceeded ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11369/1/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: http://gerrit.cloudera.org:8080/#/c/11369/1/be/src/exec/hdfs-scan-node.cc@441 PS1, Line 441: break; > Would it make sense to add a TRACE log when we exceed the memory limit? sure, i'll add a VLOG. I think we already do something to try to avoid spinning up too many threads, but not sure of the details. In the context of this patch, though, I was just trying to fix the hang without changing the overall design here. -- To view, visit http://gerrit.cloudera.org:8080/11369 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3dc1a2ec79c823575d7d40e7b52216dea5b0ddde Gerrit-Change-Number: 11369 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 30 Aug 2018 23:12:19 +0000 Gerrit-HasComments: Yes
