Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 )
Change subject: IMPALA-376: add built-in functions for parsing JSON ...................................................................... Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/10950/13/common/function-registry/impala_functions.py File common/function-registry/impala_functions.py: http://gerrit.cloudera.org:8080/#/c/10950/13/common/function-registry/impala_functions.py@514 PS13, Line 514: get_json_object > I'd prefer to make Hive compatibility be explicity brought up before decidi Ah, haven't considered the ANSI standards before. My initial motivation is to replace the Hive UDF get_json_object written in Java since it's out of control in memory management. There's a slight difference between the Hive get_json_object() and ANSI json_value(). json_value only returns scalar values, while get_json_object can return JSON string for a selected JSON object. Maybe the ANSI json_query() function is more similar. In Hulu, most of our Impala users are already using the get_json_object function. Some upper systems may also use this function. Since it's already a Hive convention, I think it worths to keep this name. My principle is "start from the user". Rename the function may cause trouble for them. However, the ANSI standards have more flexible syntax. What about creating a new JIRA for implementing the "returning <type>" and "value on error" clauses? -- To view, visit http://gerrit.cloudera.org:8080/10950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a9d3598cb3beca0865a7edb094f3a5b602dbd2f Gerrit-Change-Number: 10950 Gerrit-PatchSet: 13 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Greg Rahn <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 06 Sep 2018 00:14:05 +0000 Gerrit-HasComments: Yes
