Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11380 )
Change subject: IMPALA-5031: Allow UBSAN to be set on codegen ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11380/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11380/1//COMMIT_MSG@12 PS1, Line 12: is not made the default when using -ubsan. Might be worth mentioning that it only works on C++ code cross-compiled to LLVM IR. I.e. not on IrBuilder generated IR. You can sort of infer this since IrBuilder code isn't C++ so the concept doesn't apply, but good to be explicit. http://gerrit.cloudera.org:8080/#/c/11380/1/be/src/common/logging.h File be/src/common/logging.h: http://gerrit.cloudera.org:8080/#/c/11380/1/be/src/common/logging.h@49 PS1, Line 49: // The number of function calls replaced is not knowable when UBSAN is enabled, since it This might belong better in a codegen-related header? It feels very specific to that use case. llvm-codegen.h? -- To view, visit http://gerrit.cloudera.org:8080/11380 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I054e78dd172ee140f2095a523595ff030494e560 Gerrit-Change-Number: 11380 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 06 Sep 2018 17:49:24 +0000 Gerrit-HasComments: Yes
