Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11380 )
Change subject: IMPALA-5031: Allow UBSAN to be set on codegen ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11380/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11380/1//COMMIT_MSG@12 PS1, Line 12: slows down testing significantly, it is not made the default when > Might be worth mentioning that it only works on C++ code cross-compiled to Done http://gerrit.cloudera.org:8080/#/c/11380/1/be/src/common/logging.h File be/src/common/logging.h: http://gerrit.cloudera.org:8080/#/c/11380/1/be/src/common/logging.h@49 PS1, Line 49: /// Define verbose logging levels. Per-row logging is more verbase than per-file / > This might belong better in a codegen-related header? It feels very specifi Done -- To view, visit http://gerrit.cloudera.org:8080/11380 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I054e78dd172ee140f2095a523595ff030494e560 Gerrit-Change-Number: 11380 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 07 Sep 2018 03:12:39 +0000 Gerrit-HasComments: Yes
