Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11511 )
Change subject: IMPALA-7531: Daemon level catalog cache metrics ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/11511/1/be/src/util/impalad-metrics.h File be/src/util/impalad-metrics.h: http://gerrit.cloudera.org:8080/#/c/11511/1/be/src/util/impalad-metrics.h@134 PS1, Line 134: /// Ratio of Impalad Catalog cache requests that were hits. Is this since the beginning of time? http://gerrit.cloudera.org:8080/#/c/11511/1/common/thrift/metrics.json File common/thrift/metrics.json: http://gerrit.cloudera.org:8080/#/c/11511/1/common/thrift/metrics.json@1697 PS1, Line 1697: "key": "catalog.cache.average-load-time" I think it's super confusing that a metric for Impalad starts with "catalog". I worry that it'll cause some confusion. Perhaps start them with "impalad_catalog" or something? http://gerrit.cloudera.org:8080/#/c/11511/1/fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java File fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java: http://gerrit.cloudera.org:8080/#/c/11511/1/fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java@370 PS1, Line 370: if (!(provider instanceof CatalogdMetaProvider)) return; Is this possible? -- To view, visit http://gerrit.cloudera.org:8080/11511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23c131b77ca84aa4df8919213bbd83944fa112a5 Gerrit-Change-Number: 11511 Gerrit-PatchSet: 1 Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Tue, 25 Sep 2018 20:41:32 +0000 Gerrit-HasComments: Yes
