Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11511 )
Change subject: IMPALA-7531: Daemon level catalog cache metrics ...................................................................... Patch Set 3: Code-Review+2 (1 comment) comment about sync'ing the text in the .h and json files, otherwise, lgtm. http://gerrit.cloudera.org:8080/#/c/11511/3/common/thrift/metrics.json File common/thrift/metrics.json: http://gerrit.cloudera.org:8080/#/c/11511/3/common/thrift/metrics.json@1720 PS3, Line 1720: "description": "Ratio of Impalad Catalog cache requests that were hits.", are you sync'ing these to the comments in the .h file? This one was updated. -- To view, visit http://gerrit.cloudera.org:8080/11511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23c131b77ca84aa4df8919213bbd83944fa112a5 Gerrit-Change-Number: 11511 Gerrit-PatchSet: 3 Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Wed, 26 Sep 2018 00:08:50 +0000 Gerrit-HasComments: Yes
