Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11511 )
Change subject: IMPALA-7531: Daemon level catalog cache metrics ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/11511/1/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/11511/1/be/src/service/impala-server.cc@1212 PS1, Line 1212: e_miss_count if there's a miss, there's a load? just wondering it they're redundant. I see from the screenshot that there are 16 misses, but 14 loads. What happened with the other two misses? http://gerrit.cloudera.org:8080/#/c/11511/1/fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java File fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java: http://gerrit.cloudera.org:8080/#/c/11511/1/fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java@370 PS1, Line 370: if (!(provider instanceof CatalogdMetaProvider)) return; > Is this possible? Not now, but there is another one called DirectMetaProvider that's easy to swap in. I think it makes sense to keep this here as-is or move it to the interface. http://gerrit.cloudera.org:8080/#/c/11511/1/tests/custom_cluster/test_local_catalog.py File tests/custom_cluster/test_local_catalog.py: http://gerrit.cloudera.org:8080/#/c/11511/1/tests/custom_cluster/test_local_catalog.py@35 PS1, Line 35: def get_debug_page(self, page_url): : """Returns the content of the debug page 'page_url' as json.""" : response = requests.get(page_url) : assert response.status_code == requests.codes.ok : return json.loads(response.text) use get_debug_webpage_json from impala_service.py -- To view, visit http://gerrit.cloudera.org:8080/11511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23c131b77ca84aa4df8919213bbd83944fa112a5 Gerrit-Change-Number: 11511 Gerrit-PatchSet: 1 Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Tue, 25 Sep 2018 21:09:27 +0000 Gerrit-HasComments: Yes
