Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11511 )
Change subject: IMPALA-7531: Daemon level catalog cache metrics ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/11511/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11511/3//COMMIT_MSG@13 PS3, Line 13: These metrics are refreshed at the end of planning, for each query run. > This is pretty weird. Can you update impala-server.h to include a note on t Done, I made it to update metrics regardless of the type of query. http://gerrit.cloudera.org:8080/#/c/11511/3/common/thrift/Frontend.thrift File common/thrift/Frontend.thrift: http://gerrit.cloudera.org:8080/#/c/11511/3/common/thrift/Frontend.thrift@116 PS3, Line 116: 12: optional double cache_hit_rate > You answered my question about whether this is since beginning of time; cou Added it in the header, updated here too. http://gerrit.cloudera.org:8080/#/c/11511/3/tests/custom_cluster/test_local_catalog.py File tests/custom_cluster/test_local_catalog.py: http://gerrit.cloudera.org:8080/#/c/11511/3/tests/custom_cluster/test_local_catalog.py@250 PS3, Line 250: # A mix of queries of various types. > Different query types have slightly different paths from impala-server.cc. Done -- To view, visit http://gerrit.cloudera.org:8080/11511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23c131b77ca84aa4df8919213bbd83944fa112a5 Gerrit-Change-Number: 11511 Gerrit-PatchSet: 4 Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Thu, 27 Sep 2018 21:31:51 +0000 Gerrit-HasComments: Yes
