Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11511 )
Change subject: IMPALA-7531: Daemon level catalog cache metrics ...................................................................... Patch Set 3: (3 comments) Took another pass. I had to scratch my head a little about how the updates work. I think this wouldn't update metrics for "create table" statements, or "explain" statements, and I think that's probably a bug. (Or likely I'm missing something.) http://gerrit.cloudera.org:8080/#/c/11511/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11511/3//COMMIT_MSG@13 PS3, Line 13: These metrics are refreshed at the end of planning, for each query run. This is pretty weird. Can you update impala-server.h to include a note on the docs for UpdateCatalogMetrics() about when they're updated? I think they're updated at the end of planning as well as when there are statestore callbacks? http://gerrit.cloudera.org:8080/#/c/11511/3/common/thrift/Frontend.thrift File common/thrift/Frontend.thrift: http://gerrit.cloudera.org:8080/#/c/11511/3/common/thrift/Frontend.thrift@116 PS3, Line 116: 12: optional double cache_hit_rate You answered my question about whether this is since beginning of time; could you answer it here as a comment? Thanks! http://gerrit.cloudera.org:8080/#/c/11511/3/tests/custom_cluster/test_local_catalog.py File tests/custom_cluster/test_local_catalog.py: http://gerrit.cloudera.org:8080/#/c/11511/3/tests/custom_cluster/test_local_catalog.py@250 PS3, Line 250: query = "select count(*) from functional.alltypes" Different query types have slightly different paths from impala-server.cc. (e.g.,: if (result.stmt_type == TStmtType::DDL) { Status status = UpdateCatalogMetrics(); ) Do we need to check that these are getting updated for a variety of different queries? E.g., "explain", "select", and "create table"? -- To view, visit http://gerrit.cloudera.org:8080/11511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23c131b77ca84aa4df8919213bbd83944fa112a5 Gerrit-Change-Number: 11511 Gerrit-PatchSet: 3 Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Wed, 26 Sep 2018 21:19:56 +0000 Gerrit-HasComments: Yes
