David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11546 )
Change subject: IMPALA-7647: Add HS2/Impyla dimension to TestQueries ...................................................................... Patch Set 6: (3 comments) A few preliminary comments to start off with. More to come. http://gerrit.cloudera.org:8080/#/c/11546/6/tests/beeswax/impala_beeswax.py File tests/beeswax/impala_beeswax.py: http://gerrit.cloudera.org:8080/#/c/11546/6/tests/beeswax/impala_beeswax.py@82 PS6, Line 82: if self.schema.fieldSchemas is not None If there exists a possibility that self.schema.fieldSchemas might be None, then L81 might fail with a TypeError ('NoneType' object is not iterable.) http://gerrit.cloudera.org:8080/#/c/11546/6/tests/common/impala_connection.py File tests/common/impala_connection.py: http://gerrit.cloudera.org:8080/#/c/11546/6/tests/common/impala_connection.py@51 PS6, Line 51: def sql_stmt(self): This is not something you need to change, but for what it's worth, there's something non-pythonic about accessor methods like this. It's more common to either allow clients to simply access the internal attributes directly, or to use the @property decorator. http://gerrit.cloudera.org:8080/#/c/11546/6/tests/common/impala_connection.py@217 PS6, Line 217: class ImpylaHS2Connection(ImpalaConnection): This now means that we have another way of connecting via Impyla. See also: https://github.com/apache/impala/blob/master/tests/comparison/db_connection.py#L847 https://github.com/apache/impala/blob/master/tests/conftest.py#L20 These are used by the query generator or anywhere the unique_cursor fixture is used in the Kudu tests: https://github.com/apache/impala/blob/master/tests/query_test/test_kudu.py Now we're adding a third way. I'm not sure if this is something we need to be concerned about, or not. I just wanted to raise the issue in case it wasn't obvious to people, and so that we can all discuss it. -- To view, visit http://gerrit.cloudera.org:8080/11546 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9908ccc4d3df50365be8043b883cacafca52661e Gerrit-Change-Number: 11546 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Nithya Janarthanan <[email protected]> Gerrit-Comment-Date: Tue, 02 Oct 2018 22:57:55 +0000 Gerrit-HasComments: Yes
