Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11546 )
Change subject: IMPALA-7647: Add HS2/Impyla dimension to TestQueries ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/11546/6/tests/beeswax/impala_beeswax.py File tests/beeswax/impala_beeswax.py: http://gerrit.cloudera.org:8080/#/c/11546/6/tests/beeswax/impala_beeswax.py@82 PS6, Line 82: if self.schema.fieldSchemas is not None > If there exists a possibility that self.schema.fieldSchemas might be None, I carried this logic over from parse_column_labels() before the changes, but you're right that it doesn't (and didn't) make sense. http://gerrit.cloudera.org:8080/#/c/11546/6/tests/common/impala_connection.py File tests/common/impala_connection.py: http://gerrit.cloudera.org:8080/#/c/11546/6/tests/common/impala_connection.py@217 PS6, Line 217: class ImpylaHS2Connection(ImpalaConnection): > This is a valid point. I tried to minimise changes to the current connectio I looked a little more and I don't see an obvious way to consolidate the two different APIs right now. The alternative connection API really seems to be a thin wrapper around dbapi so it only really useful if the client code wants a dbapi interface, which the impala test runner code doesn't. That might be the right long-term direction but untangling that would be a big task. It gets a lot simpler once we can remove Beeswax support and simplify the interface here but I didn't want to go down that path with this patch. -- To view, visit http://gerrit.cloudera.org:8080/11546 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9908ccc4d3df50365be8043b883cacafca52661e Gerrit-Change-Number: 11546 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Nithya Janarthanan <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 02 Oct 2018 23:47:14 +0000 Gerrit-HasComments: Yes
