Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11546 )
Change subject: IMPALA-7647: Add HS2/Impyla dimension to TestQueries ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/11546/6/tests/common/impala_connection.py File tests/common/impala_connection.py: http://gerrit.cloudera.org:8080/#/c/11546/6/tests/common/impala_connection.py@217 PS6, Line 217: class ImpylaHS2Connection(ImpalaConnection): > This now means that we have another way of connecting via Impyla. See also: This is a valid point. I tried to minimise changes to the current connection interface. It seems like the alternative DB connection API you pointed to has a very different higher-level interface that works for multiple different databases, so not sure how much we would gain from merging this connection abstraction and the other. -- To view, visit http://gerrit.cloudera.org:8080/11546 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9908ccc4d3df50365be8043b883cacafca52661e Gerrit-Change-Number: 11546 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Nithya Janarthanan <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 02 Oct 2018 23:02:52 +0000 Gerrit-HasComments: Yes
