Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11561 )
Change subject: WIP IMPALA-7626: Throttle catalog partial RPC requests ...................................................................... Patch Set 4: (7 comments) for testing, depending on that new metric might be racy. probably easiest to do this via the junit tests. perhaps you can make that "do..." method protected and override it with a sleep to make it easier to check the average queue len over a longer duration. http://gerrit.cloudera.org:8080/#/c/11561/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11561/4//COMMIT_MSG@16 PS4, Line 16: are blocked until the current requests are serviced. Adds the following or they timeout http://gerrit.cloudera.org:8080/#/c/11561/4/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/11561/4/be/src/catalog/catalog-server.cc@a237 PS4, Line 237: we lost this message-- was it useful? what's shown instead? http://gerrit.cloudera.org:8080/#/c/11561/4/be/src/catalog/catalog-server.cc@71 PS4, Line 71: Should Must ... I think there's even a precondition that checks it. http://gerrit.cloudera.org:8080/#/c/11561/4/be/src/catalog/catalog-server.cc@71 PS4, Line 71: for access to the resources nit: to run http://gerrit.cloudera.org:8080/#/c/11561/4/common/thrift/BackendGflags.thrift File common/thrift/BackendGflags.thrift: http://gerrit.cloudera.org:8080/#/c/11561/4/common/thrift/BackendGflags.thrift@103 PS4, Line 103: parallel_runs parallel_runs sounds odd. perhaps max_catalog_parallel_partial_rpc ? http://gerrit.cloudera.org:8080/#/c/11561/4/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/11561/4/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2113 PS4, Line 2113: public TGetPartialCatalogObjectResponse getPartialCatalogObject method doc http://gerrit.cloudera.org:8080/#/c/11561/4/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2118 PS4, Line 2118: permit ? -- To view, visit http://gerrit.cloudera.org:8080/11561 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11f77a16cfa38ada42d8b7c859850198ea7dd142 Gerrit-Change-Number: 11561 Gerrit-PatchSet: 4 Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Wed, 03 Oct 2018 00:12:48 +0000 Gerrit-HasComments: Yes
