Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11561 )
Change subject: IMPALA-7626: Throttle catalog partial RPC requests ...................................................................... Patch Set 6: (5 comments) lgtm. mostly nits/stale messages. http://gerrit.cloudera.org:8080/#/c/11561/6/be/src/catalog/catalog-server.h File be/src/catalog/catalog-server.h: http://gerrit.cloudera.org:8080/#/c/11561/6/be/src/catalog/catalog-server.h@94 PS6, Line 94: partial_rpc_call rpc_call has a bit of redundancy. I also read this as "partial_rpc", which looks odd. how about partial_fetch_rpc_queue_len_metric_? http://gerrit.cloudera.org:8080/#/c/11561/6/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/11561/6/be/src/catalog/catalog-server.cc@382 PS6, Line 382: while(1) nit: while (true) seems to be more commonly used here. http://gerrit.cloudera.org:8080/#/c/11561/6/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/11561/6/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@247 PS6, Line 247: catalog_partial_rpc_max_parallel_runs stale: catalog_max_parallel_partial_rpc http://gerrit.cloudera.org:8080/#/c/11561/6/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2119 PS6, Line 2119: nit: extra line http://gerrit.cloudera.org:8080/#/c/11561/6/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2130 PS6, Line 2130: catalog_partial_rpc_max_parallel_runs stale -- To view, visit http://gerrit.cloudera.org:8080/11561 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11f77a16cfa38ada42d8b7c859850198ea7dd142 Gerrit-Change-Number: 11561 Gerrit-PatchSet: 6 Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Thu, 04 Oct 2018 05:06:05 +0000 Gerrit-HasComments: Yes
