Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11561 )
Change subject: IMPALA-7626: Throttle catalog partial RPC requests ...................................................................... Patch Set 5: (3 comments) Looks fine to me. It's a little bit weird that for catalog metrics we have a thread updating the, and for the JVM Memory Metrics I did some caching recently. It turns out to be largely the same thing, but we're definitely inconsistent. http://gerrit.cloudera.org:8080/#/c/11561/4/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/11561/4/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@246 PS4, Line 246: .getCatalogPartialRpcQueueTimeoutS(); Do we usually do these as "static"? I don't like thinking about class loader order, so I think if you remove "static" it'll be just as good and not sensitive to that. http://gerrit.cloudera.org:8080/#/c/11561/5/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/11561/5/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@248 PS5, Line 248: // Used to track the number of concurrent partial RPC requests, for testing purposes Semaphore.availablePermits() isn't good enough? Do you know what's not reliable about it? http://gerrit.cloudera.org:8080/#/c/11561/5/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2136 PS5, Line 2136: if (RuntimeEnv.INSTANCE.isTestEnv()) concurrentPartialReqCount_.incrementAndGet(); Worrying about test env here seems that it's likely pre-mature optimization. -- To view, visit http://gerrit.cloudera.org:8080/11561 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11f77a16cfa38ada42d8b7c859850198ea7dd142 Gerrit-Change-Number: 11561 Gerrit-PatchSet: 5 Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Wed, 03 Oct 2018 23:43:24 +0000 Gerrit-HasComments: Yes
