Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11568 )
Change subject: IMPALA-7484: Do not interpret unrecognized hints as straight_join hints. ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/11568/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11568/4//COMMIT_MSG@7 PS4, Line 7: Do not interpret unrecognized hints as > We typically describe the fix rather than the problem, something like Done http://gerrit.cloudera.org:8080/#/c/11568/4//COMMIT_MSG@9 PS4, Line 9: > Remove. No need to describe the commit. Better to keep the commit message h Done http://gerrit.cloudera.org:8080/#/c/11568/4//COMMIT_MSG@14 PS4, Line 14: Change-Id: Icf600ebbfefc7398e0896df143a0ab91545cae04 : : > Same as above. Maybe just say something like, added unit tests for positive Done http://gerrit.cloudera.org:8080/#/c/11568/4/fe/src/main/java/org/apache/impala/analysis/SelectList.java File fe/src/main/java/org/apache/impala/analysis/SelectList.java: http://gerrit.cloudera.org:8080/#/c/11568/4/fe/src/main/java/org/apache/impala/analysis/SelectList.java@86 PS4, Line 86: if (hint.is("straight_join")) { : analyzer.setIsStraightJoin(); : } else { : analyzer.addWarning("PLAN hint not recognized: " + hint); : } > nit: How about inverting it? I think that is more readable. Done http://gerrit.cloudera.org:8080/#/c/11568/4/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java: http://gerrit.cloudera.org:8080/#/c/11568/4/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@1849 PS4, Line 1849: > An improvement to this collection of tests would be to wrap the pattern of Done -- To view, visit http://gerrit.cloudera.org:8080/11568 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf600ebbfefc7398e0896df143a0ab91545cae04 Gerrit-Change-Number: 11568 Gerrit-PatchSet: 5 Gerrit-Owner: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Wed, 03 Oct 2018 23:01:15 +0000 Gerrit-HasComments: Yes
