Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11568 )
Change subject: IMPALA-7484: Do not interpret unrecognized hints as straight_join hints. ...................................................................... Patch Set 6: (2 comments) lgtm, couple of formatting issues. not sure why the checks didn't complain about these. http://gerrit.cloudera.org:8080/#/c/11568/6/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java: http://gerrit.cloudera.org:8080/#/c/11568/6/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@1825 PS6, Line 1825: /** indentation is off http://gerrit.cloudera.org:8080/#/c/11568/6/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@1841 PS6, Line 1841: "select %sstraight_join%s * from functional.alltypes", prefix, suffix),null)); add a space (and several more below) -- To view, visit http://gerrit.cloudera.org:8080/11568 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf600ebbfefc7398e0896df143a0ab91545cae04 Gerrit-Change-Number: 11568 Gerrit-PatchSet: 6 Gerrit-Owner: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Thu, 04 Oct 2018 00:15:18 +0000 Gerrit-HasComments: Yes
