Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11568 )
Change subject: IMPALA-7484: Do not interpret unrecognized hints as straight_join hints. ...................................................................... Patch Set 6: (5 comments) Changed existing tests to use the wrapper to test the state of straight_join hint for each test. http://gerrit.cloudera.org:8080/#/c/11568/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java: http://gerrit.cloudera.org:8080/#/c/11568/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@1830 PS5, Line 1830: An > I was expecting all of these cases to use the wrapper. We'll get more cover Done http://gerrit.cloudera.org:8080/#/c/11568/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@1852 PS5, Line 1852: null)); > pls reword this so its clear that this does not test the hint (just returns Done http://gerrit.cloudera.org:8080/#/c/11568/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@1855 PS5, Line 1855: %sstr > replace "check" with "has" Done http://gerrit.cloudera.org:8080/#/c/11568/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@1855 PS5, Line 1855: "select %sstraight_join,straight_join%s * from functional.alltypes", > put the helper before its use, e.g., on L1824 Done http://gerrit.cloudera.org:8080/#/c/11568/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@1858 PS5, Line 1858: > what's this comment for? Done -- To view, visit http://gerrit.cloudera.org:8080/11568 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf600ebbfefc7398e0896df143a0ab91545cae04 Gerrit-Change-Number: 11568 Gerrit-PatchSet: 6 Gerrit-Owner: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Wed, 03 Oct 2018 23:42:02 +0000 Gerrit-HasComments: Yes
