Anuj Phadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11540 )
Change subject: [WIP] IMPALA-7555: Set socket timeout in impala-shell ...................................................................... Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/11540/1/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/11540/1/shell/impala_client.py@261 PS1, Line 261: protocol = TBinaryProtocol.TBinaryProtocol(self.transport) > This explains why: https://docs.python.org/2/library/socket.html#socket.soc Done http://gerrit.cloudera.org:8080/#/c/11540/4/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/11540/4/shell/impala_client.py@280 PS4, Line 280: the kerberized version, a sasl transport is created. > Please keep the order consistent between the name, the comment, and the ret Done http://gerrit.cloudera.org:8080/#/c/11540/1/shell/impala_shell_config_defaults.py File shell/impala_shell_config_defaults.py: http://gerrit.cloudera.org:8080/#/c/11540/1/shell/impala_shell_config_defaults.py@54 PS1, Line 54: 'client_connect_timeout_ms': 5000, > Some stress testing in a larger cluster under load would be good. See the c Will try that. http://gerrit.cloudera.org:8080/#/c/11540/3/shell/option_parser.py File shell/option_parser.py: http://gerrit.cloudera.org:8080/#/c/11540/3/shell/option_parser.py@225 PS3, Line 225: "-t", "--client_connect_timeout_ms" > That's also a fine option. It seems the current behavior with 0 is not well anuj@anuj-OptiPlex-9020:~/Impala$ anuj@anuj-OptiPlex-9020:~/Impala$ ./bin/impala-shell.sh -i anuj-timeout-3.gce.cloudera.com:21000 --ssl -q "show tables" Starting Impala Shell without Kerberos authentication SSL is enabled. Impala server certificates will NOT be verified (set --ca_cert to change) Error connecting: TTransportException, Could not connect to anuj-timeout-3.gce.cloudera.com:21000: _ssl.c:495: The handshake operation timed out Not connected to Impala, could not execute queries. ------Without timeout set to 0 it was stuck. anuj@anuj-OptiPlex-9020:~/Impala$ ./bin/impala-shell.sh -i anuj-timeout-3.gce.cloudera.com:21000 --ssl -q "show tables" -t 0 Starting Impala Shell without Kerberos authentication SSL is enabled. Impala server certificates will NOT be verified (set --ca_cert to change) http://gerrit.cloudera.org:8080/#/c/11540/4/shell/option_parser.py File shell/option_parser.py: http://gerrit.cloudera.org:8080/#/c/11540/4/shell/option_parser.py@227 PS4, Line 227: connect > connect to Impala server. Done http://gerrit.cloudera.org:8080/#/c/11540/4/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/11540/4/tests/shell/test_shell_commandline.py@749 PS4, Line 749: '-q "select foo; select bar;" -t 2000 -i localhost:%d' % (test_port) > nit: no need for '+': Done -- To view, visit http://gerrit.cloudera.org:8080/11540 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I130fc47f7a83f591918d6842634b4e5787d00813 Gerrit-Change-Number: 11540 Gerrit-PatchSet: 5 Gerrit-Owner: Anuj Phadke <[email protected]> Gerrit-Reviewer: Anuj Phadke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Comment-Date: Wed, 03 Oct 2018 23:46:20 +0000 Gerrit-HasComments: Yes
