Anuj Phadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11540 )
Change subject: IMPALA-7555: Set socket timeout in impala-shell ...................................................................... Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/11540/5/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/11540/5/shell/impala_client.py@81 PS5, Line 81: self.fetch_batch_size = 1024 > nit: move below use_ldap to follow order or arguments Done http://gerrit.cloudera.org:8080/#/c/11540/5/shell/impala_client.py@255 PS5, Line 255: if self.client_connect_timeout_ms > 0: > This comment can be moved to above line 264. Done http://gerrit.cloudera.org:8080/#/c/11540/5/shell/impala_client.py@258 PS5, Line 258: protocol = TBinaryProtocol.TBinaryProtocol(self.transport) : self.imp_service = Impa > Given sock is just returned from self._get_socket_and_transport(), I don't Done http://gerrit.cloudera.org:8080/#/c/11540/5/shell/option_parser.py File shell/option_parser.py: http://gerrit.cloudera.org:8080/#/c/11540/5/shell/option_parser.py@224 PS5, Line 224: parser.add_option("-t", "--client_connect_timeout_ms", > nit: no newline, follow surrounding code Done http://gerrit.cloudera.org:8080/#/c/11540/5/shell/option_parser.py@227 PS5, Line 227: " timeout.") > Set to 0 to disable any timeout. Done -- To view, visit http://gerrit.cloudera.org:8080/11540 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I130fc47f7a83f591918d6842634b4e5787d00813 Gerrit-Change-Number: 11540 Gerrit-PatchSet: 6 Gerrit-Owner: Anuj Phadke <[email protected]> Gerrit-Reviewer: Anuj Phadke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Comment-Date: Wed, 10 Oct 2018 20:27:08 +0000 Gerrit-HasComments: Yes
