Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11540 )
Change subject: [WIP] IMPALA-7555: Set socket timeout in impala-shell ...................................................................... Patch Set 5: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/11540/5/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/11540/5/shell/impala_client.py@255 PS5, Line 255: # Setting a timeout of None disables timeouts on socket operations This comment can be moved to above line 264. http://gerrit.cloudera.org:8080/#/c/11540/5/shell/impala_client.py@258 PS5, Line 258: else: : sock.setTimeout(None) Given sock is just returned from self._get_socket_and_transport(), I don't think this line is needed. http://gerrit.cloudera.org:8080/#/c/11540/5/shell/option_parser.py File shell/option_parser.py: http://gerrit.cloudera.org:8080/#/c/11540/5/shell/option_parser.py@227 PS5, Line 227: " if it fails to connect to Impala server") Set to 0 to disable any timeout. -- To view, visit http://gerrit.cloudera.org:8080/11540 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I130fc47f7a83f591918d6842634b4e5787d00813 Gerrit-Change-Number: 11540 Gerrit-PatchSet: 5 Gerrit-Owner: Anuj Phadke <[email protected]> Gerrit-Reviewer: Anuj Phadke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Comment-Date: Tue, 09 Oct 2018 01:42:52 +0000 Gerrit-HasComments: Yes
