Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11556 )
Change subject: IMPALA-6323 Allow constant "partition by" expressions. ...................................................................... Patch Set 2: (1 comment) lgtm, just a minor style comment. http://gerrit.cloudera.org:8080/#/c/11556/2/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java File fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java: http://gerrit.cloudera.org:8080/#/c/11556/2/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java@91 PS2, Line 91: { remove the braces (project convention). -- To view, visit http://gerrit.cloudera.org:8080/11556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf129026c45120e9470df601268863634037908c Gerrit-Change-Number: 11556 Gerrit-PatchSet: 2 Gerrit-Owner: Michal Ostrowski <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Fri, 05 Oct 2018 17:30:01 +0000 Gerrit-HasComments: Yes
