Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11556 )
Change subject: IMPALA-6323 Allow constant "partition by" expressions. ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/11556/3/fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java File fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java: http://gerrit.cloudera.org:8080/#/c/11556/3/fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java@436 PS3, Line 436: "Expressions in the ORDER BY clause must not be constant: " I think the JIRA was originally intended to cover removing this case too. I'm fine with splitting into two smaller commits but we should fix this too. I noticed this by looking at discrepancy_searcher.py (part of the random query generator). I was looking there because I figured we'd want random query generator coverage for this, then I realised I didn't know why these errors didn't cause RQG failures already - turns out it skips over queries that return this error. -- To view, visit http://gerrit.cloudera.org:8080/11556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf129026c45120e9470df601268863634037908c Gerrit-Change-Number: 11556 Gerrit-PatchSet: 3 Gerrit-Owner: Michal Ostrowski <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Fri, 05 Oct 2018 19:07:30 +0000 Gerrit-HasComments: Yes
