Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11638 )
Change subject: IMPALA-7669: Gracefully handle concurrent invalidate/partial fetch RPCs ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11638/1/fe/src/main/java/org/apache/impala/catalog/IncompleteTable.java File fe/src/main/java/org/apache/impala/catalog/IncompleteTable.java: http://gerrit.cloudera.org:8080/#/c/11638/1/fe/src/main/java/org/apache/impala/catalog/IncompleteTable.java@144 PS1, Line 144: if (cause_ == null) { : throw new TableLoadingException("Table state on the Catalog server has been " + : "invalidated by another concurrent request. Please retry the query."); > perhaps, but I'm actually still a little confused how we get to this case i The problem seems to be here [1] (I added some additional logging to confirm that). If a racy invalidate changes the table state, we return the invalidated table [2]. [1] https://github.com/apache/impala/blob/0047191262d6a90eb704dff880efe6e625b805bc/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java#L1317 [2] https://github.com/apache/impala/blob/0047191262d6a90eb704dff880efe6e625b805bc/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java#L1341 -- To view, visit http://gerrit.cloudera.org:8080/11638 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8533f73f25ca42a20f146ddfd95d4213add9b705 Gerrit-Change-Number: 11638 Gerrit-PatchSet: 1 Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Thu, 11 Oct 2018 22:32:45 +0000 Gerrit-HasComments: Yes
