Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11638 )
Change subject: IMPALA-7669: Gracefully handle concurrent invalidate/partial fetch RPCs ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11638/1/fe/src/main/java/org/apache/impala/catalog/IncompleteTable.java File fe/src/main/java/org/apache/impala/catalog/IncompleteTable.java: http://gerrit.cloudera.org:8080/#/c/11638/1/fe/src/main/java/org/apache/impala/catalog/IncompleteTable.java@144 PS1, Line 144: // distinguish between these scenarios based on 'cause_'. : if (cause_ == null) { : TGetPartialCatalogObjectResponse resp = new TGetPartialCatalogObjectRespon > I was looking at the callers of this. I see a few of them actually expect t I've stared at the code ([3]) for a bit and I don't think it is affected by it being an IncompleteTable. Looks like we are only interested in the backing hms table for rest of the method. So, I'm leaving it as is. (Please correct me if you think I got something wrong). -- To view, visit http://gerrit.cloudera.org:8080/11638 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8533f73f25ca42a20f146ddfd95d4213add9b705 Gerrit-Change-Number: 11638 Gerrit-PatchSet: 2 Gerrit-Owner: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Mon, 15 Oct 2018 23:35:39 +0000 Gerrit-HasComments: Yes
